Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing left hand column on login page #54

Open
mgage opened this issue Oct 2, 2012 · 1 comment
Open

missing left hand column on login page #54

mgage opened this issue Oct 2, 2012 · 1 comment

Comments

@mgage
Copy link
Sponsor Member

mgage commented Oct 2, 2012

anybody know why the login & logout pages no longer have the the "Courses" link in the Main Menu box?

@mgage
Copy link
Sponsor Member Author

mgage commented Oct 6, 2012

Hi everyone,

Ionparticle on IRC noticed that the main menu and links to courses are no longer showing up
on the Login page and the Logout page.

Before I return the main menu (which contains only a link to the page listing all the courses) what are the use
cases for and against having this link on the Login and Logout pages?

There seems to have been some back and forth on whether having this link is desirable.

Here is the most recent commit where the link disappeared:

openwebwork/webwork2@c71b80f

And here is an earlier and related commit:

Seems to be a long standing debate, there's a commit 7 years ago that commented out links in Logout.pm: openwebwork/webwork2@30a4fb0

What is the consensus? Should the main menu with the link to "Courses" appear on the Login and Logout pages or not?

Thanks to ionparticle for researching this for us.

Take care,

Mike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant