Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for default action parameters #26

Closed
wants to merge 1 commit into from
Closed

Conversation

ddragosd
Copy link

@ddragosd ddragosd commented Feb 6, 2017

This is still WIP , I'd like to add integration tests but I didn't quite figure it out how to execute them locally.

@pritidesai
Copy link
Member

How about "npm test" from home dir "~/openwhisk-client-js/"?

This link has lot of details:
https://travis-ci.org/openwhisk/openwhisk-client-js/jobs/199010764

Cheers
Priti

@jthomas
Copy link
Member

jthomas commented Feb 7, 2017

@ddragosd Did you see this README? https://github.com/openwhisk/openwhisk-client-js/tree/master/test/integration

Is there something else missing? Running npm run-script test-integration should run the suite once the env vars are set up or you can install ava locally and just run the single file.

@ddragosd
Copy link
Author

thanks @jthomas . I'll start a local OW instance to run the integration tests and add them to the PR. We may also have to add ignore_certs:true when configuring the JS client.

In a separate PR we could maybe also automate the execution of these tests including the setup with the actions/triggers.

@jthomas
Copy link
Member

jthomas commented Mar 18, 2017

I'm closing this as I manually merged the code into a recent release.

@jthomas jthomas closed this Mar 18, 2017
@csantanapr csantanapr deleted the issue-25 branch August 3, 2017 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants