Add the missing double quote to the field baseUrl for deployment application #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcastro
reviewed
Mar 27, 2017
tests/dat/deploy1.yaml
Outdated
| @@ -1,4 +1,6 @@ | |||
| application: | |||
| name: wskdeploy-samples | |||
| namespace: /wskdeploy/samples/ | |||
| credential: 23bc46b1-71f6-4ed5-8c54-816aa4f8c502:123zO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP | |||
There was a problem hiding this comment.
I assume this is not a read credential?
There was a problem hiding this comment.
Oh, I need to change it to something less sensitive.
There was a problem hiding this comment.
@paulcastro that key is not sensitive, it's the default key for user guest from openwhisk core repo used for testing.
https://github.com/openwhisk/openwhisk/blob/master/ansible/files/auth.guest
…ication Since there is a missing double quote for the field baseUrl, it is unable to be parsed. This PR adds the quote to field baseUrl making it able to be parsed. Besides, this PR adds the test coverage to parse baseUrl and credential. Closes-Bug: #205
csantanapr
approved these changes
Mar 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is a missing double quote for the field baseUrl, it is unable
to be parsed. This PR adds the quote to field baseUrl making it able to
be parsed.
Besides, this PR adds the test coverage to parse baseUrl and credential.
Closes-Bug: #205