Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batman-adv and friends: improve version string #529

Merged
merged 3 commits into from Dec 15, 2019

Conversation

adschm
Copy link
Member

@adschm adschm commented Nov 11, 2019

This changes the package version string so it does not start
with "openwrt", but with the base version we are modifying:

So far: openwrt-2019.4-1
Now: 2019.4-openwrt-1

Since it's us modifying version 2019.4 (in this case), this order
is more convenient (and also closer to what the kernel version
string does).

This changes the package version string so it does not start
with "openwrt", but with the base version we are modifying:

So far: openwrt-2019.4-1
Now:    2019.4-openwrt-1

Since it's us modifying version 2019.4 (in this case), this order
is more convenient (and also closer to what the kernel version
string does).

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
This changes the package version string so it does not start
with "openwrt", but with the base version we are modifying:

So far: openwrt-2019.4-1
Now:    2019.4-openwrt-1

Since it's us modifying version 2019.4 (in this case), this order
is more convenient (and also closer to what the kernel version
string does).

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
This changes the package version string so it does not start
with "openwrt", but with the base version we are modifying:

So far: openwrt-2019.4-1
Now:    2019.4-openwrt-1

Since it's us modifying version 2019.4 (in this case), this order
is more convenient (and also closer to what the kernel version
string does).

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
@adschm
Copy link
Member Author

adschm commented Nov 11, 2019

@ecsv @simonwunderlich

@adschm
Copy link
Member Author

adschm commented Dec 15, 2019

@ecsv @simonwunderlich Ping.

@adschm
Copy link
Member Author

adschm commented Dec 15, 2019

One could also think about a more kernel-like 2019.4+openwrt1

@ecsv
Copy link
Contributor

ecsv commented Dec 15, 2019

One could also think about a more kernel-like 2019.4+openwrt1

This looks somewhat good. But I am not the person merging these things.

The current scheme is more inspired how Debian marks there kernel versions (with "Debian " in front of the version number):

$ uname -v
#1 SMP Debian 4.19.67-2+deb10u2 (2019-11-11)

@simonwunderlich simonwunderlich merged commit 5544be5 into openwrt:master Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants