Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibreRouter-v1 support lacks watchdog driver #10856

Closed
ilario opened this issue Sep 30, 2022 · 3 comments
Closed

LibreRouter-v1 support lacks watchdog driver #10856

ilario opened this issue Sep 30, 2022 · 3 comments

Comments

@ilario
Copy link
Contributor

ilario commented Sep 30, 2022

LibreRouter-v1 has been supported since OpenWrt 19.07 with 24463d0 by @spiccinini.
It gets shipped with LibreRouterOS 1.5 based on LibreMesh 2020.1 based on OpenWrt 19.07.

During BattleMesh v14, @T-X realized that the hardware watchdog (more details here https://gitlab.com/librerouter/watchdog-fw and here https://gitlab.com/librerouter/boards) was not interacted with by the kernel (neither when using OpenWrt 22.03.0 nor with 19.07.10) as reported here freifunk-gluon/gluon#2654, even if the instructions for that are included in the DTS file here:

watchdog {
compatible = "linux,wdt-gpio";
gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
hw_algo = "toggle";
hw_margin_ms = <1000>;
always-running;
};

This means that during LibreRouterOS compilation some kernel modules/features are selected and these should be used also for compiling OpenWrt images for the LibreRouter-v1.
The interesting option should be one of these:
https://gitlab.com/librerouter/librerouteros/-/blob/7d02a29f8ca932b6edf747fb709d6f2d6ef0842e/configs/default_config

@spiccinini
Copy link
Contributor

spiccinini commented Sep 30, 2022

Thanks Ilario for reporting it!

I forgot to upstream this fix when I added 19.07 support to LibreRouterOs last year... https://gitlab.com/librerouter/librerouteros/-/commit/bab27e8a20bcbef4abb003c2fb416a3ec3731652

@blocktrron
Copy link
Member

Fixed with #10859

@ilario
Copy link
Contributor Author

ilario commented Oct 2, 2022

Amazing! Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants