Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rstrip.sh breaks private rpaths via PATCHELF --set-rpath #10783

Closed
Andy2244 opened this issue Dec 13, 2019 · 2 comments
Closed

rstrip.sh breaks private rpaths via PATCHELF --set-rpath #10783

Andy2244 opened this issue Dec 13, 2019 · 2 comments

Comments

@Andy2244
Copy link
Contributor

Andy2244 commented Dec 13, 2019

Maintainer: @jow- @neheb
Environment: all

Description:
Samba4 by default uses two rpaths, one public (/usr/lib) and a private (/usr/lib/samba), so all bins have those set to: /usr/lib/samba:/usr/lib
The default RSTRIP macro will break those paths via rstrip.sh to:
/usr/lib/samba XXXXXXXX

This results in broken bin's and my temp fix is this:
RSTRIP:=:

Just wanted to ask if this is a bug we want to fix, by allowing multiple rpaths in bins, if they are defined or keep as samba4 specific build quirk?

PS: The main use-case is to avoid/circumvent build issues and let samba use some of its own bundled system lib versions, like tevent or tdb, com_err and than make those private to avoid breaking other packages.

@jow-
Copy link
Contributor

jow- commented Dec 16, 2019

The rstrip.sh script is supposed to retain paths starting with /lib or /usr/lib so I'm not sure whats wrong there. Maybe try adding some debug echos to rstrip.sh

@neheb
Copy link
Contributor

neheb commented Jan 17, 2020

RSTRIP:=: is used in multiple places. I assume for similar reasons.

In any case, if this is really a bug, it belongs at https://bugs.openwrt.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants