Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust failed to build #21095

Closed
oskarirauta opened this issue May 19, 2023 · 16 comments
Closed

Rust failed to build #21095

oskarirauta opened this issue May 19, 2023 · 16 comments

Comments

@oskarirauta
Copy link
Contributor

Rust has issues with musl- missing 64bit definitions of some types and commands. My host is running with musl as well, adding largefile64 define to host_cflags and host_cxxflags did not help.

@oskarirauta
Copy link
Contributor Author

@1715173329 @lu-zero
Ping

@lu-zero
Copy link
Contributor

lu-zero commented May 19, 2023

@lu-zero
Copy link
Contributor

lu-zero commented May 19, 2023

Either we stay with musl-1.2.3 until the update is sorted out or we'll need to carry owned bootstrap binaries for 1.2.4

@lu-zero
Copy link
Contributor

lu-zero commented May 19, 2023

@oskarirauta
Copy link
Contributor Author

oskarirauta commented May 19, 2023

Either we stay with musl-1.2.3 until the update is sorted out or we'll need to carry owned bootstrap binaries for 1.2.4

We have already gone to 1.2.4..
openwrt/openwrt@fff878c

@oskarirauta
Copy link
Contributor Author

On alpine they chose to patch musl instead of all packages with issues..

https://git.alpinelinux.org/aports/tree/main/musl/lfs64-2.patch

@oskarirauta
Copy link
Contributor Author

@lu-zero

dirty patch at gentoo discussion did not work. Same result.

@lu-zero
Copy link
Contributor

lu-zero commented May 19, 2023

Once the musl support is rolled in upstream one low impact solution is to build a beta or a nightly snapshot that has the support so everything works until there is a stable release.

@oskarirauta
Copy link
Contributor Author

oskarirauta commented May 19, 2023

Seems still be quite far from that..

@oskarirauta
Copy link
Contributor Author

oskarirauta commented May 19, 2023

rust builds without issues with alpine's patches. Using them fixes all recent musl related issues, but makes your build non-standard and prevents from working with fixes for those musl related issues.

But if you are working with something else, and just have to get stuff built, rust for example - this will give you a huge head start to that.
openwrt/openwrt#12667

@1715173329
Copy link
Member

Rust 1.70.0 was released and the issue seemed fixed.

@lu-zero
Copy link
Contributor

lu-zero commented Jun 2, 2023

If you didn't beat me already I'll update it tomorrow (as I'm also preparing related releases)

@1715173329
Copy link
Member

Aha nice waiting for your PR!

@lu-zero
Copy link
Contributor

lu-zero commented Jun 5, 2023

#21270 should had addressed it, please confirm :)

@1715173329
Copy link
Member

hmmmm libc 0.2.145 update was not included in rust 1.70.0 ;(

@1715173329
Copy link
Member

fixed by #21296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants