Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keepalived: notify script handling is broken or undocumented #24021

Open
stintel opened this issue Apr 26, 2024 · 1 comment · May be fixed by #24037
Open

keepalived: notify script handling is broken or undocumented #24021

stintel opened this issue Apr 26, 2024 · 1 comment · May be fixed by #24037

Comments

@stintel
Copy link
Member

stintel commented Apr 26, 2024

@feckert

The notify options in the default keepalived UCI config suggest you can put a path to a script. This is misleading, as they are handled by hotplug-call, which is handled by /etc/hotplug.d/keepalived/01-user, which only calls /etc/keepalived.user. If you configure a path to e.g. /etc/keepalived/notify.sh in UCI, this script is never called. This leads to completely broken failover scenarios that are non-trivial to debug.

@feckert
Copy link
Member

feckert commented Apr 29, 2024

@stintel Thanks for the hint.
As far as I can tell, however, this has never worked!

I have opend a PR to remove the uci notify script options.
If the script should be called, it must be placed into /etc/hotplug.d/keepalived.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants