Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of messages to be changed to match openxc-message-format #265

Closed
vkanishk opened this issue Mar 1, 2017 · 4 comments
Closed

Name of messages to be changed to match openxc-message-format #265

vkanishk opened this issue Mar 1, 2017 · 4 comments

Comments

@vkanishk
Copy link

vkanishk commented Mar 1, 2017

Currently the messages displayed in enabler is not matching the openxc-message-format.

e.g. "Accelerator Pedal". It should be "accelerator_pedal_position"

@peplin
Copy link
Member

peplin commented Apr 1, 2017

I don't have a strong preference, but this was on purpose - there is a mapping between the raw JSON ID and "pretty" version meant for output in a UI:

int identifier = context.getResources().getIdentifier(

Any message without a known mapping uses the raw ID string.

@emarsman
Copy link
Member

emarsman commented Apr 3, 2017

I like the pretty version too. However, that is only defined in Android. I think we should make the pretty version official and use it everywhere (see below) if we want it. Not sure it's worth it at this point or just always use the "official" name.

https://github.com/openxc/openxc-message-format#official-signals
http://openxcplatform.com/about/data-set.html
https://github.com/openxc/openxc-python/blob/7b22cac7e5f311c871aa339de6d06b4f774a63f2/openxc/measurements.py
iOS
trace files(?)

@alokonly
Copy link
Member

@emarsman as per our discussion can we close this or do you want to discuss more about it?

@alokonly
Copy link
Member

Closing as not required right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants