Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing sub-byte emulation support for memref.alloca #15515

Closed
hanhanW opened this issue Nov 9, 2023 · 2 comments · Fixed by llvm/llvm-project#73138
Closed

Missing sub-byte emulation support for memref.alloca #15515

hanhanW opened this issue Nov 9, 2023 · 2 comments · Fixed by llvm/llvm-project#73138
Assignees
@Max191
Labels
codegen Shared code generation infrastructure and dialects

Comments

@hanhanW
Copy link
Contributor

hanhanW commented Nov 9, 2023

@Max191 reports the issue this morning. The emulation is missing at this moment. It should be as same as what has been done for memref.alloc.

https://github.com/llvm/llvm-project/blob/9ef829097bbc4cf908698e3891af11a154e1d3e2/mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp#L59

Assigning it to @Max191 for now. If you are not working at it, please reassign it to @saienduri
@hanhanW hanhanW added the codegen Shared code generation infrastructure and dialects label Nov 9, 2023
@Max191
Copy link
Contributor

Max191 commented Nov 9, 2023

I have a patch that adds support for this. I am triaging some other issues that came up at the moment, but I can try to send it out tomorrow.

@hanhanW
Copy link
Contributor Author

hanhanW commented Nov 9, 2023

Nice, thanks for pushing on this!

@hanhanW hanhanW mentioned this issue Nov 15, 2023
Closed
@hanhanW hanhanW mentioned this issue Nov 27, 2023
Merged
hanhanW pushed a commit to llvm/llvm-project that referenced this issue Nov 28, 2023
@Max191
[mlir] Add support for memref.alloca sub-byte emulation (#73138)
b823f84 
Adds a similar case to `memref.alloc` for `memref.alloca` in
EmulateNarrowTypes.

Fixes iree-org/iree#15515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Max191 Max191

Labels
codegen Shared code generation infrastructure and dialects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mlir] Add support for memref.alloca sub-byte emulation Max191/llvm-project
2 participants
@hanhanW @Max191