Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RenderDoc API integration in the Vulkan backend #52

Closed
benvanik opened this issue Oct 13, 2019 · 0 comments
Closed

Add RenderDoc API integration in the Vulkan backend #52

benvanik opened this issue Oct 13, 2019 · 0 comments
Assignees
@ScottTodd
Labels
enhancement ➕ New feature or request
Projects
Runtime Optimization

Comments

@benvanik
Copy link
Collaborator

RenderDoc provides a rich API by which we can trigger capture and demarcate "frames" (probably just top-level invocations). We can add comments to frames that show in the UI which would make it easier to map back to original invocations. RenderDoc can also capture stack traces on calling into the Vulkan API entry points which would be useful when using the sequencer codegen (otherwise we'd just see VM stacks).
@benvanik benvanik added the enhancement ➕ New feature or request label Oct 13, 2019
@benvanik benvanik added this to the Benchmarking Infrastructure milestone Oct 13, 2019
@benvanik benvanik added this to Ideas in Runtime Optimization via automation Oct 13, 2019
@ScottTodd ScottTodd self-assigned this Jan 31, 2020
@ScottTodd ScottTodd mentioned this issue Feb 6, 2020
Closed
copybara-service bot pushed a commit that referenced this issue Feb 7, 2020
@ScottTodd
Import renderdoc_app.h to iree/third_party, with build defs.
d624815 
Progress on #52. We can use RenderDoc without integrating with its API through `vulkan_inference_gui`, but not through `iree-run-mlir`. We need to explicitly start/stop capture through the API when only using Vulkan compute (no graphics). This PR imports the API header file so we can use it in future change.

Includes are of the format (tested with Bazel and CMake):

```
#include "third_party/renderdoc_api/app/renderdoc_app.h"
```

Closes #696

PiperOrigin-RevId: 293834602
ScottTodd added a commit to ScottTodd/iree that referenced this issue Feb 7, 2020
@ScottTodd
Integrate RenderDoc's API into iree/hal/vulkan.
fe1cc7f 
Surface level progress on iree-org#52 that lets us record captures from `iree-run-mlir` (with the latest nightly build of RenderDoc).
ScottTodd added a commit to ScottTodd/iree that referenced this issue Feb 7, 2020
@ScottTodd
Integrate RenderDoc's API into iree/hal/vulkan.
f9add9f 
Surface level progress on iree-org#52 that lets us record captures from `iree-run-mlir` (with the latest nightly build of RenderDoc).
@ScottTodd ScottTodd mentioned this issue Feb 7, 2020
Closed
copybara-service bot pushed a commit that referenced this issue Feb 12, 2020
@ScottTodd
Integrate RenderDoc's API into iree/hal/vulkan.
7c914e4 
Surface level progress on #52 that lets us record captures from `iree-run-mlir` (with the latest nightly build of RenderDoc).

Closes #710

COPYBARA_INTEGRATE_REVIEW=#710 from ScottTodd:vulkan-renderdoc 9f1a5c0
PiperOrigin-RevId: 294776511
@ScottTodd ScottTodd mentioned this issue Mar 13, 2020
Closed
copybara-service bot pushed a commit that referenced this issue Mar 16, 2020
@ScottTodd
Add note about working RenderDoc versions now that 1.7 is released.
b83301b 
Previously only nightly builds had the necessary fixes for IREE.

Relates to #52.

Closes #1078

COPYBARA_INTEGRATE_REVIEW=#1078 from ScottTodd:renderdoc-docs cda32d5
PiperOrigin-RevId: 301258967
Runtime Optimization automation moved this from Ideas to Done Mar 19, 2020
@GMNGeoffrey GMNGeoffrey mentioned this issue Mar 29, 2023
Merged
@gabeweisz gabeweisz mentioned this issue Mar 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ScottTodd ScottTodd

Labels
enhancement ➕ New feature or request
Projects
No open projects
Runtime Optimization
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benvanik @ScottTodd