Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from using the benchmark C++ API to our iree/testing/benchmark.h API and flags. #5669

Open
benvanik opened this issue Apr 29, 2021 · 0 comments
Labels
cleanup 🧹 platform/generic 🔩 Bare metal/generic target build, execution, benchmarking, and deployment runtime/tools IREE's runtime tooling (iree-run-module, iree-benchmark-module, etc)
Projects

Comments

@benvanik
Copy link
Collaborator

benchmark's default flag handling doesn't work well for when a project also has their own handling. As part of the work to get our benchmarks running on bare metal we now have a (mostly complete) mapping of their API in C at iree/testing/benchmark.h. As part of this we can use the new flags support to have our own versions of the benchmark library flags that we use to provide consistent flags across all target devices whether using benchmark or not. It'll also let us use our flag verification instead of having to do UNDEFOK and ignoring typos in flags.

There's a TODO here:
https://github.com/google/iree/blob/cb5434134c0dfac50d7de4a1a965b5fe6d484c2d/iree/hal/local/executable_library_benchmark.c#L388-L394

and then iree-benchmark-module (and a few other files) should be switched to use the C API and custom flags parsing.

@benvanik benvanik added runtime/tools IREE's runtime tooling (iree-run-module, iree-benchmark-module, etc) cleanup 🧹 platform/generic 🔩 Bare metal/generic target build, execution, benchmarking, and deployment labels Apr 29, 2021
@benvanik benvanik added this to To do in Tiny IREE via automation Apr 29, 2021
@KoolJBlack KoolJBlack self-assigned this Jul 12, 2021
@KoolJBlack KoolJBlack removed their assignment Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 platform/generic 🔩 Bare metal/generic target build, execution, benchmarking, and deployment runtime/tools IREE's runtime tooling (iree-run-module, iree-benchmark-module, etc)
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants