Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Python bindings builds/tests in 'runtime' CI builds. #15878

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable Python bindings builds/tests in 'runtime' CI builds. #15878

wants to merge 1 commit into from

Conversation

ScottTodd
Copy link
Collaborator

Hoping to add more coverage for these tests:
image

Some of the tests use compiler APIs though: https://github.com/openxla/iree/blob/278bcf0283769a1303fa6a9205527940da653a17/runtime/bindings/python/CMakeLists.txt#L256-L258

@ScottTodd ScottTodd added infrastructure Relating to build systems, CI, or testing bindings/python Python wrapping IREE's C API labels Dec 11, 2023
@ScottTodd ScottTodd mentioned this pull request Dec 11, 2023
Open
@ScottTodd ScottTodd marked this pull request as ready for review December 11, 2023 18:03
@ScottTodd
Copy link
Collaborator Author

Ping?

@ScottTodd ScottTodd mentioned this pull request Feb 15, 2024
Open
@ScottTodd ScottTodd marked this pull request as draft May 20, 2024 21:18
@ScottTodd
Copy link
Collaborator Author

ScottTodd commented May 20, 2024 •
edited
Loading

Seeing some errors after syncing: https://github.com/iree-org/iree/actions/runs/9164893455/job/25197219527?pr=15878#step:4:1068

/work/runtime/bindings/python/io.cc:217:26: error: no member named 'bool_' in namespace 'nanobind'
        if (py::cast<py::bool_>(self_object.attr("is_host_allocation"))) {
                     ~~~~^
/work/runtime/bindings/python/io.cc:217:32: error: type name requires a specifier or qualifier
        if (py::cast<py::bool_>(self_object.attr("is_host_allocation"))) {
                               ^

edit: fixed by installing build requirements (via python venv)

@ScottTodd ScottTodd removed the request for review from pzread May 20, 2024 21:41
@ScottTodd ScottTodd marked this pull request as ready for review May 20, 2024 21:45
@ScottTodd ScottTodd requested a review from sogartar May 20, 2024 21:45
@ScottTodd
Copy link
Collaborator Author

Ping, @sogartar I think you wanted to build off of this?

@ScottTodd
Enable Python bindings builds/tests in 'runtime' CI builds.
bb95d67 
Add `IREE_BUILD_SETUP_PYTHON_VENV` to a few jobs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellaraccident stellaraccident Awaiting requested review from stellaraccident stellaraccident is a code owner

@sogartar sogartar Awaiting requested review from sogartar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bindings/python Python wrapping IREE's C API infrastructure Relating to build systems, CI, or testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ScottTodd