Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] provide --config option for yurtadm #1448

Closed
YTGhost opened this issue May 10, 2023 · 3 comments · Fixed by #1547
Closed

[feature request] provide --config option for yurtadm #1448

YTGhost opened this issue May 10, 2023 · 3 comments · Fixed by #1547
Assignees
Labels
kind/feature kind/feature

Comments

@YTGhost
Copy link
Member

YTGhost commented May 10, 2023

What would you like to be added:
Add the --config option for yurtadm

Why is this needed:
Users can customize parameters such as network-plugin using a custom kubeadm config. When this option is set, the process of building the kubeadm config file during yurtadm join is skipped.

others
/kind feature

@YTGhost YTGhost added the kind/feature kind/feature label May 10, 2023
@YTGhost
Copy link
Member Author

YTGhost commented May 10, 2023

/assign

@rambohe-ch
Copy link
Member

@YTGhost as discussed in the issue: #1438 , it is not need to provide --config parameter in yurtadm join command, and you should improve yurtadm join command to use kubeadm-config configmap.

@YTGhost
Copy link
Member Author

YTGhost commented Jun 9, 2023

@YTGhost as discussed in the issue: #1438 , it is not need to provide --config parameter in yurtadm join command, and you should improve yurtadm join command to use kubeadm-config configmap.

After analyzing the kubeadm join code, the kubeadm join process has actually pulled the kubeadm-config configmap, which only contains the contents of ClusterConfiguration and cannot configure the contents of our required JoinConfiguration. Therefore, we still need to add a new --config option to yurtadm join to support user-defined JoinConfiguration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants