Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect image display in the Gallery #1428

Open
Ubuntu-2020 opened this issue Apr 4, 2021 · 15 comments
Open

Incorrect image display in the Gallery #1428

Ubuntu-2020 opened this issue Apr 4, 2021 · 15 comments
Labels
bug upstream wikimedia Direct impact on Wikimedia content scraping
Milestone

Comments

@Ubuntu-2020
Copy link

Kiwix extension for FireFox.
If the word thumb is written in the Photo Gallery, then the image in the ZIM file is displayed with an error (second picture):
Error second image

And this is what the Gallery in Wikipedia looks like:
Original-web

@kelson42
Copy link
Collaborator

kelson42 commented Apr 4, 2021

@MananJethwani A nice bug for you ;)

@kelson42 kelson42 added this to the 1.12 milestone Apr 4, 2021
@MananJethwani
Copy link
Contributor

will start working on it soon

@MananJethwani
Copy link
Contributor

@kelson42 this is because of different width and height of image at Wikipedia, open the page source and search for Tem2-215 observe that width is 120 but when we fetch the mobile version the same tag has a width 300 same is for the height.

so final point is it's an upstream bug.

@kelson42
Copy link
Collaborator

@MananJethwani I don't have verified, but please open an upstream bug (an link it here), if the upstream HTML is broken.

@kelson42 kelson42 added upstream wikimedia Direct impact on Wikimedia content scraping and removed bug labels Apr 26, 2021
@MananJethwani
Copy link
Contributor

@kelson42 done https://phabricator.wikimedia.org/T281125

@Ubuntu-2020
Copy link
Author

Ubuntu-2020 commented May 24, 2021

@MananJethwani @kelson42
The same situation Diego Garcia in ZIM file:
Diego-Garsia

And this is what the Diego Garcia in Wikipedia looks like:
Diego-Garsia wiki

PS: maybe the error has already been fixed, I just can't check.

@stale
Copy link

stale bot commented Jul 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Jul 24, 2021
@stale
Copy link

stale bot commented Sep 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Sep 22, 2021
@stale stale bot removed the stale label Jun 26, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2022
@kelson42 kelson42 modified the milestones: 1.14.0_old, 1.14.0 Jan 20, 2023
@stale stale bot removed the stale label Jan 20, 2023
@kelson42 kelson42 self-assigned this Mar 23, 2023
@kelson42 kelson42 modified the milestones: 1.14.0, 1.13.0 Mar 23, 2023
@kelson42
Copy link
Collaborator

@pavel-karatsiuba Please do the analysis

@pavel-karatsiuba
Copy link
Contributor

From API we are getting images with the bigger size.
It is an upstream bug: page with bug
We can fix it by adding a function to treat the gallery section.

@kelson42
Copy link
Collaborator

@pavel-karatsiuba Then please open bug upstream at https://phabricator.wikimedia.org/ and link both tickets together.

@pavel-karatsiuba
Copy link
Contributor

pavel-karatsiuba commented Mar 26, 2023

@kelson42 Upstream ticket created: https://phabricator.wikimedia.org/T333122

@kelson42
Copy link
Collaborator

kelson42 commented Apr 5, 2023

@pavel-karatsiuba Thx, it looks like it will be deprecated by implementing #1664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug upstream wikimedia Direct impact on Wikimedia content scraping
Projects
None yet
Development

No branches or pull requests

5 participants