Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Articles in Vikidia zim files doesn't have id in headings #24

Closed
automactic opened this issue Oct 1, 2016 · 5 comments
Closed

Articles in Vikidia zim files doesn't have id in headings #24

automactic opened this issue Oct 1, 2016 · 5 comments
Labels

Comments

@automactic
Copy link
Member

Problem:
In Vikidia zim files, h2, h3 elements doesn't have id. Table of content system needs id to scroll an element to viewport.

Example:
In vikidia_en_all_2016-09.zim, article European Union, header <h2> Member countries </h2> doesn't have id. Javascript couldn't scroll to this element if user select this header in table of contents.

@kelson42
Copy link
Collaborator

kelson42 commented Oct 2, 2016

Is that a new problem?

@kelson42
Copy link
Collaborator

@automactic Have you fixed Kiwix for iOS to get the table of content working even if no "id' ? This is important.

@automactic
Copy link
Member Author

automactic commented Oct 18, 2016

I don't plan to implement another algorithm for no-id situation. So I might give an id to all children of mw-content-text. But I strongly suggest to fix this on the zim making side, so clients can be lazier. Besides, most zim files have id in heading tags.

@kelson42
Copy link
Collaborator

The "id" attribute is not mandatory in HTML and the HTML we have in ZIM files is not generated by us, but by the Mediawiki backend (in the case of Wikipedai). Kiwix should therefore not rely on it.

@kelson42
Copy link
Collaborator

I have open a bug on iOS side kiwix/kiwix-apple#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants