Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python-scraperlib shared logic to handle description and long_description #64

Closed
benoit74 opened this issue Aug 14, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@benoit74
Copy link
Collaborator

See openzim/python-scraperlib#110 once implemented

@HimaTeju
Copy link

@benoit74 Is this issue fixed? Because here it is mentioned upgrade to 3.x already done.

@benoit74
Copy link
Collaborator Author

No, issue still needs to be done. Upgrade to 3.x is already done like mentioned, but the upgrade of python-scraperlib still has to be done, including supporting description and long_description with the new compute_descriptions function introduced in python-scraperlib.

It is very important to note that first thing to do is hence to start the scraper locally and understand how it works, and observe the ZIM content with current codebase. Once the upgrade will be done, you will have to do the same and confirm there is no regression. We won't accept PR without details of manual tests executed.

@HimaTeju
Copy link

I don't know if this is the best place to enquire about this but, What is the best way to work with these Repos? I'm on windows 11, I got suggestions from the Slack community to use WSL. Can I use Docker or WSL is the best to work on this? (I'm new to Linux also)

@rgaudin
Copy link
Member

rgaudin commented Mar 15, 2024

WSL will allow you tu setup the dev environment directly. You can also install and use docker inside WSL I believe

@HimaTeju
Copy link

Thank you!

@benoit74
Copy link
Collaborator Author

WSL is useful if you want to directly launch Python from your machine. Docker is the other alternative, does not need at all to be launched from within WSL. Docker Desktop or Rancher Desktop are probably good candidates to run Docker containers on Windows.

PS: this enquiry would be better placed on Slack, or at least in a new issue this has nothing to do with the fact that we need to use python-scraperlib shared logic to handle description and long_description.

@kelson42 kelson42 added this to the 1.2.0 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants