Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python-scraperlib to 3.x, including CLI support for description / long_description flags #181

Open
Tracked by #21
benoit74 opened this issue Aug 14, 2023 · 4 comments

Comments

@benoit74
Copy link
Collaborator

See openzim/overview#21

@jo780-full
Copy link

The changes to be made in scraper.py , entrypoint.py. Kindly assign this task to me

@jo780-full
Copy link

I have made the changes by adding a function that handles the checks the description length instead of the if else in the return in
get_zim_info function.

@jo780-full
Copy link

also favicon in the make zim file is now illustrations , not longer favicon

@jo780-full
Copy link

#183 kindly check this

@kelson42 kelson42 pinned this issue Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants