Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize python repos to 3.11 #13

Open
rgaudin opened this issue Dec 21, 2022 · 9 comments
Open

Harmonize python repos to 3.11 #13

rgaudin opened this issue Dec 21, 2022 · 9 comments
Assignees

Comments

@rgaudin
Copy link
Member

rgaudin commented Dec 21, 2022

For the sake of harmonization and ease of dev/maint, we want to use a single major Python version as base for all our python projects.

Following https://en.wikipedia.org/wiki/History_of_Python#Table_of_versions, we want to use 3.11 as of now.
As such, support for python 3.6 (not receiving secu updates) and 3.7 (secu updates to end in 6m) will be dropped from those projects.

@rgaudin rgaudin self-assigned this Dec 21, 2022
@kelson42
Copy link
Contributor

@rgaudin In an attempt to help external people to step-in, would you be able please here to give the list of concerned repositories with maybe a bullet list of points to take care?

@rgaudin
Copy link
Member Author

rgaudin commented Dec 21, 2022

Kind of the point of this ticket to figure this out.

List of repos:

What's on kiwix doesn't really fall into the python-repo category.

What I have in mind:

  • Make sure it works. 3.6 code is mostly forward compatible except a couple changed API like with typing. This would mostly mean creating a new 3.11 environment and make sure that dependencies are compatible and can be installed ; potentially updating some.
  • update workflows to run actions on 3.8-3.11
  • Update docker image to use a an image with the appropriate python version
  • Update descriptions/readme/changelog to reflect the change

@mgautierfr
Copy link

There is kiwix-build also

@kelson42
Copy link
Contributor

I propose as well to use that badge PyPI - Python Version

@stale
Copy link

stale bot commented May 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@benoit74
Copy link
Contributor

I realize that I've probably misunderstood this PR so far; I've understood that we want to support only one single Python version (3.11 here) while it looks like the original idea was more to support a range of active versions (3.8 to 3.11 originally) and deploy (Docker) with on single version (3.11).

Should I revert some changes so that scrapers codes are still compatible with 3.8 and 3.9?

Now that Docker is mostly mainstream, I don't see a huge benefit in supporting 3 Python versions for scrapers which are mostly always "end-products", while it obviously limit what is possible with code, and since we usually have no automated tests for scrapers I'm pretty sure there will be some errors which won't be catch.

But maybe I'm too pessimistic + a bit lazy ^^

Nota: now that 3.12 is out, I'm aware we will very soon switch to 3.9 to 3.12 once scraperlib is ready

@rgaudin
Copy link
Member Author

rgaudin commented Dec 22, 2023

@benoit74 RTFM 😅

@benoit74
Copy link
Contributor

Thank you for your very good memory! As usual I forgot about the manual, there is just so many 🤣 Good news is that I was right in my changes (I knew it came from somewhere), latest single version is ok for scrapers, it was just not reflected in this issue (and I became worried for nothing, but I'm better safe than sorry that been said 😉)

@rgaudin
Copy link
Member Author

rgaudin commented Dec 22, 2023

Yes I think this issue predates the bootstrap and our knowledge management is organic 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants