Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python-scraperlib to 3.x, including CLI support for description / long_description flags #175

Closed
Tracked by #21
benoit74 opened this issue Aug 14, 2023 · 8 comments · Fixed by #202
Closed
Tracked by #21
Assignees
Milestone

Comments

@benoit74
Copy link
Collaborator

See openzim/overview#21

@dikshant182004
Copy link

I hope this message finds you well. I'm Dikshant jha and I am eager to contribute to this open-source issue. After reading the project and its documentation, I think this can be the right fit as a potential task to work on as my first contribution.

I am new to open-source contributions, and I would greatly appreciate your mentorship and guidance as I get started.
If you have some time, could we schedule a brief chat or exchange messages to discuss this further? I'm eager to learn and contribute to the project's success.

Thank you for considering my request. I look forward to your response

@benoit74
Copy link
Collaborator Author

Thank you @dikshant182004 for your proposition to help. I will contact you on Slack, it will be easier to discuss there.

@dikshant182004
Copy link

okay, Let's discuss on slack

@rgaudin rgaudin pinned this issue Oct 9, 2023
@benoit74 benoit74 added this to the 2.2.0 milestone Oct 13, 2023
@benoit74
Copy link
Collaborator Author

We must also update Jinja2 at the same time, and get rid of markupsafe explicit version.

@benoit74
Copy link
Collaborator Author

And check if if not isinstance(html, str): in render_template is still needed.

@benoit74
Copy link
Collaborator Author

And upgrade to Python 3.11 (or 3.12 if zimscraperlib has been updated to support it)

@benoit74 benoit74 modified the milestones: 2.2.0, 2.3.0 Nov 17, 2023
@benoit74
Copy link
Collaborator Author

benoit74 commented Nov 21, 2023

Cannot be done before #186 is solved. Otherwise, many zimfarm recipe will fail due to invalid metadata.

@benoit74
Copy link
Collaborator Author

benoit74 commented Nov 21, 2023

Cannot be done before #147 in fact (#186 is a duplicate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment