Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scraper is not using logo and banner from the first playlists channel? #200

Open
RavanJAltaie opened this issue Apr 23, 2024 · 10 comments
Open

Comments

@RavanJAltaie
Copy link

Hello, I have an enhancement suggestion that will save time and enhance youtube files quality.
Can we update the Youtube scraper in a way that it scrapes the logo of the channel and the banner automatically from the channel ID while scraping the content?

@rgaudin
Copy link
Member

rgaudin commented Apr 24, 2024

It's already the case for channels and playlists have no such thing AFAIK

@rgaudin
Copy link
Member

rgaudin commented Apr 24, 2024

Closing ; reopen if I'm missing anything

@rgaudin rgaudin closed this as completed Apr 24, 2024
@RavanJAltaie
Copy link
Author

Can't we apply the same thing on playlists?
The playlists are coming from a channel, so adding the channel logo and banner would be very useful.

@RavanJAltaie RavanJAltaie reopened this Apr 24, 2024
@rgaudin
Copy link
Member

rgaudin commented Apr 25, 2024

This issue is not actionable. You need to explain what you would like, and why.

You mention saving time so you can only be talking about ZIM Illustration. Those are already fetched by the scraper. It's from the channel/user or the first playlist's channel.

If you are not only talking about ZIM illustration then describe what you get and what you expect.

@benoit74
Copy link
Collaborator

@RavanJAltaie could you explain what you don't get and would like to get with current scraper? Is this just a lack of documentation?

@benoit74
Copy link
Collaborator

@RavanJAltaie should we discuss it live or may I close the issue? We need more details to help you on this

@RavanJAltaie
Copy link
Author

@benoit74 @rgaudin the scraper is taking the logo and banner if it's a channel.
If it's a playlist, it doesn't. Resulting in a file with no logo and banner, and then we need to enter them manually after checking for files with no logos.

@benoit74
Copy link
Collaborator

I just checked the code, and I confirm that if it's a playlist (or a list of playlist), scraper is supposed to use the logo and banner of the channel of the playlist (or first playlist in the list if we have multiple playlists).

So this is not a feature request, but a bug report.

I checked one random recipe using a playlist as ID (https://farm.openzim.org/recipes/avanti-alkyhalide/config) and the ZIM has both a logo and a banner (https://library.kiwix.org/viewer#avanti-alkyhalide_2024-03/home.html).

image

@RavanJAltaie please provide more information on where this is not working so we can help you debug this issue

@benoit74 benoit74 added this to the 3.0.0 milestone May 20, 2024
@benoit74 benoit74 changed the title Scraper to import logo and banner from the channel/playlist Scraper is not using logo and banner from the first playlists channel? May 20, 2024
@benoit74
Copy link
Collaborator

Nota: the banner is a custom file provided in recipe configuration, I forgot to check that, sorry, but the logo/profile is not specified so it is fetched from online.

@benoit74 benoit74 modified the milestones: 2.3.0, 3.0.0 May 22, 2024
@benoit74 benoit74 removed this from the 3.0.0 milestone Jun 15, 2024
@benoit74
Copy link
Collaborator

Clearing milestone until what's needed is clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants