-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scraper is not using logo and banner from the first playlists channel? #200
Comments
It's already the case for channels and playlists have no such thing AFAIK |
Closing ; reopen if I'm missing anything |
Can't we apply the same thing on playlists? |
This issue is not actionable. You need to explain what you would like, and why. You mention saving time so you can only be talking about ZIM Illustration. Those are already fetched by the scraper. It's from the channel/user or the first playlist's channel. If you are not only talking about ZIM illustration then describe what you get and what you expect. |
@RavanJAltaie could you explain what you don't get and would like to get with current scraper? Is this just a lack of documentation? |
@RavanJAltaie should we discuss it live or may I close the issue? We need more details to help you on this |
I just checked the code, and I confirm that if it's a playlist (or a list of playlist), scraper is supposed to use the logo and banner of the channel of the playlist (or first playlist in the list if we have multiple playlists). So this is not a feature request, but a bug report. I checked one random recipe using a playlist as ID (https://farm.openzim.org/recipes/avanti-alkyhalide/config) and the ZIM has both a logo and a banner (https://library.kiwix.org/viewer#avanti-alkyhalide_2024-03/home.html). @RavanJAltaie please provide more information on where this is not working so we can help you debug this issue |
Nota: the banner is a custom file provided in recipe configuration, I forgot to check that, sorry, but the logo/profile is not specified so it is fetched from online. |
Clearing milestone until what's needed is clear |
Hello, I have an enhancement suggestion that will save time and enhance youtube files quality.
Can we update the Youtube scraper in a way that it scrapes the logo of the channel and the banner automatically from the channel ID while scraping the content?
The text was updated successfully, but these errors were encountered: