Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secrets are still not hided properly #803

Closed
benoit74 opened this issue Jul 21, 2023 · 0 comments · Fixed by #808
Closed

Secrets are still not hided properly #803

benoit74 opened this issue Jul 21, 2023 · 0 comments · Fixed by #808
Assignees
@benoit74
Labels
bug

Comments

@benoit74
Copy link
Collaborator

benoit74 commented Jul 21, 2023 •
edited
Loading

  • Location: API

Problem

Secrets are still not hided properly by #799, at least not in container.command.

We had doubts regarding config.command that must not be hidden when you are logged in with sufficient rights, so we reverted the change to ensure there is no impact for workers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoit74 benoit74

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix secrets removal in UI + add support for long-description in kolibri openzim/zimfarm
1 participant
@benoit74