Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python-scraperlib to 3.x, including CLI support for description / long_description flags #202

Closed
Tracked by #21
benoit74 opened this issue Aug 14, 2023 · 5 comments

Comments

@benoit74
Copy link
Collaborator

See openzim/overview#21

@rgaudin
Copy link
Member

rgaudin commented Aug 23, 2023

Not a valid requests, zimit had those since 1.4.0 (3w old)

@rgaudin rgaudin closed this as completed Aug 23, 2023
@rgaudin rgaudin self-assigned this Aug 23, 2023
@benoit74
Copy link
Collaborator Author

@rgaudin I'm sorry, but I struggle to find how you set a long description with zimit

@rgaudin
Copy link
Member

rgaudin commented Aug 23, 2023

You're right --long-description is not passed to warc2zim. It's an easy fix. Do you want to do it? We'd need to update the ZF offliner as well so it's available everywhere

@benoit74 benoit74 reopened this Aug 23, 2023
@benoit74
Copy link
Collaborator Author

I won't do it now, but I intend to do it at some point. Feel free to do it now if you want.

@rgaudin
Copy link
Member

rgaudin commented Aug 23, 2023

Fixed

@rgaudin rgaudin closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants