zip2zim does not run locally (on OSX 10.14)

[julianharty]

git clone this repo locally onto an OSX machine (this one running 10.14)

Run the commands provided in this project's README.md

> npm i && npm start

Watch 100's of lines of messages scroll by, including many warnings about vulnerable packages (which I tried addressing however the updates didn't affect this particular issue so I reverted rather than chasing those issues).

node -v
v12.6.0
npm -v
6.9.0

node_modules/.bin/pm2 ls
┌──────────┬────┬─────────┬─────────┬─────┬─────────┬─────────┬────────┬─────┬────────┬─────────────────┬──────────┐
│ App name │ id │ version │ mode    │ pid │ status  │ restart │ uptime │ cpu │ mem    │ user            │ watching │
├──────────┼────┼─────────┼─────────┼─────┼─────────┼─────────┼────────┼─────┼────────┼─────────────────┼──────────┤
│ zip2zim  │ 0  │ 1.0.0   │ cluster │ 0   │ errored │ 30      │ 0      │ 0%  │ 0 B    │ julianharty_air │ disabled │
└──────────┴────┴─────────┴─────────┴─────┴─────────┴─────────┴────────┴─────┴────────┴─────────────────┴──────────┘

A partial extract from ~/.pm2/pm2.log

2019-07-17 12:02:50: ===============================================================================
2019-07-17 12:02:50: --- New PM2 Daemon started ----------------------------------------------------
2019-07-17 12:02:50: Time                 : Wed Jul 17 2019 12:02:50 GMT+0100 (British Summer Time)
2019-07-17 12:02:50: PM2 version          : 2.7.2
2019-07-17 12:02:50: Node.js version      : 12.6.0
2019-07-17 12:02:50: Current arch         : x64
2019-07-17 12:02:50: PM2 home             : /Users/julianharty_air/.pm2
2019-07-17 12:02:50: PM2 PID file         : /Users/julianharty_air/.pm2/pm2.pid
2019-07-17 12:02:50: RPC socket file      : /Users/julianharty_air/.pm2/rpc.sock
2019-07-17 12:02:50: BUS socket file      : /Users/julianharty_air/.pm2/pub.sock
2019-07-17 12:02:50: Application log path : /Users/julianharty_air/.pm2/logs
2019-07-17 12:02:50: Process dump file    : /Users/julianharty_air/.pm2/dump.pm2
2019-07-17 12:02:50: Concurrent actions   : 2
2019-07-17 12:02:50: SIGTERM timeout      : 1600
2019-07-17 12:02:50: ===============================================================================
2019-07-17 12:02:50: Starting execution sequence in -cluster mode- for app name:zip2zim id:0
2019-07-17 12:02:50: App name:zip2zim id:0 online
node /Users/julianharty_air/myopensourceprojects/zip2zim/build/index.js[96817]: ../src/node_contextify.cc:649:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[1]->IsString()' failed.
 1: 0x100078b00 node::Abort() [/usr/local/Cellar/node/12.6.0/bin/node]
 2: 0x1000788ad node::AppendExceptionLine(node::Environment*, v8::Local<v8::Value>, v8::Local<v8::Message>, node::ErrorHandlingMode) [/usr/local/Cellar/node/12.6.0/bin/node]
 3: 0x1000723f4 node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/Cellar/node/12.6.0/bin/node]
 4: 0x1001cd378 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [/usr/local/Cellar/node/12.6.0/bin/node]
 5: 0x1001cc746 v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<true>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/usr/local/Cellar/node/12.6.0/bin/node]
 6: 0x1001cc20a v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/usr/local/Cellar/node/12.6.0/bin/node]
 7: 0x10071ab19 Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_NoBuiltinExit [/usr/local/Cellar/node/12.6.0/bin/node]
 8: 0x10068b83a Builtins_JSBuiltinsConstructStub [/usr/local/Cellar/node/12.6.0/bin/node]
 9: 0x10076e844 Builtins_ConstructHandler [/usr/local/Cellar/node/12.6.0/bin/node]
2019-07-17 12:02:51: App name:zip2zim id:0 disconnected
2019-07-17 12:02:51: App [zip2zim] with id [0] and pid [96817], exited with code [0] via signal [SIGABRT]
2019-07-17 12:02:51: Starting execution sequence in -cluster mode- for app name:zip2zim id:0
2019-07-17 12:02:51: App name:zip2zim id:0 online
node /Users/julianharty_air/myopensourceprojects/zip2zim/build/index.js[96828]: ../src/node_contextify.cc:649:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[1]->IsString()' failed.

The pm2 output log and pm2 error log for the process are both empty.

PS: this isn't the same error as #2 from what I can tell.

[ISNIT0]

Yes, see this: #24

[julianharty]

Even if the current code isn't fit for 2019, it does actually run on Node v8 after all.
Still doesn't process the large ZIP file successfully, something to aim for with the rewrite? :)

Here's an extract of the various commands I ran for posterity. This is with a clean checkout of this codebase (removing/reverting any package dependency updates)

brew install node@8

node -v 
v8.16.0
npm -v
6.4.1

npm i && npm start
node_modules/.bin/pm2 update