Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context leak for streaming client requests #27

Closed
llinder opened this issue Jun 21, 2019 · 0 comments
Closed

Context leak for streaming client requests #27

llinder opened this issue Jun 21, 2019 · 0 comments

Comments

@llinder
Copy link
Contributor

llinder commented Jun 21, 2019

The HTTP client wrapper exhibits a context memory leak when using streaming requests. The effected code is likely here https://github.com/openzipkin-contrib/brave-ratpack/blob/master/src/main/java/ratpack/zipkin/internal/ZipkinHttpClientImpl.java#L129

This issue was originally reported by @Bijnagte and also reported that the memory leak went away if code was switched back to use a non streaming request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant