Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be great if there is es5 equivalent of this project #44

Closed
byteshiva opened this issue Sep 28, 2016 · 4 comments
Closed

It would be great if there is es5 equivalent of this project #44

byteshiva opened this issue Sep 28, 2016 · 4 comments

Comments

@byteshiva
Copy link

byteshiva commented Sep 28, 2016

it would be nice if there is a es5 equivalent of this project. I have converted this entire project to es5 using babel. but not tested completely.

https://github.com/byteshiva/zipkin-js-es5

It would be helpful, to run this project on version below node 4.1.0 or something above 0.10.35

@sveisvei
Copy link
Collaborator

We could publish with an es5/node 4 version. PR welcome for adding a buildstep that does this.

@eirslett
Copy link
Contributor

eirslett commented Sep 28, 2016

+1 for @sveisvei's solution. Redux does exactly that.

@byteshiva
Copy link
Author

I have made some changes on zipkins and thrift changes to make it work in es5/v0.10.35, Here is the gist https://gist.github.com/byteshiva/f717fb364ef0dd3f2c09ebb61da90a6d

@codefromthecrypt
Copy link
Member

I think this is a dupe of #16 please re-open if not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants