Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the Zipkin Postgres with sequelize #455

Open
saasen opened this issue Nov 5, 2019 · 1 comment
Open

Using the Zipkin Postgres with sequelize #455

saasen opened this issue Nov 5, 2019 · 1 comment

Comments

@saasen
Copy link

saasen commented Nov 5, 2019

We would love to use the zipkin-instrumentation-postgres package for tracing our Postgres calls. However, we are using an ORM which is called sequelize. This wraps the client, so the client is not available to be wrapped by the zipkin Postgres package. How would one do this? I have found an issue which kind of explains what I'm trying to do: #227. It seems like sequelize can use CLS, although I'm unsure for what reason. I guess only for passing the transaction around without manually doing it.

Do you know any way to make this work without writing our own zipkin instrumentation for sequelize?

@jcchavezs
Copy link
Contributor

Hi @saasen I had a look at the documentation (not an expert tho) and it seems the best option is to use https://sequelize.org/master/manual/hooks.html by wrapping the instance?. Are you up to take a shot on this with a PR? I can help with the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants