Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't crash when attaching to the wrong scheme #17

Closed
dovholuknf opened this issue Feb 9, 2022 · 2 comments
Closed

don't crash when attaching to the wrong scheme #17

dovholuknf opened this issue Feb 9, 2022 · 2 comments

Comments

@dovholuknf
Copy link
Member

see discourse at https://openziti.discourse.group/t/ziti-console-breaks-when-tryin-to-login-for-first-time/263

right now node is crashing when you supply http to an https endpoint. It shouldn't crash :) It should even maybe tell you "you probably screwed it up" somehow? :)

@ecelis
Copy link

ecelis commented Feb 9, 2022

I did peek at the code, if I wrap with try..catch the callback in GetPath in server.js to handle the error I prevent node crashing. Still need to look more to return some sort of error back to the user. Any pointers are welcome.

P.S. I can take over this, but not until weekend.

@JeremyTellier
Copy link
Contributor

I pushed up a fix for it, there was a little more to do just to block the ability to ever add an invalid url in the first place, but it was basically what you said with some minor tweaks, thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants