Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkeypatch bind port string is not supported #44

Closed
gberl002 opened this issue Mar 30, 2023 · 0 comments · Fixed by #49
Closed

Monkeypatch bind port string is not supported #44

gberl002 opened this issue Mar 30, 2023 · 0 comments · Fixed by #49
Labels
bug Something isn't working

Comments

@gberl002
Copy link
Contributor

gberl002 commented Mar 30, 2023

At least for the flask example, the bind options port is given in the example as a string but it should be an int otherwise the address cannot be found.

@openziti.zitify(bindings={
    ('1.2.3.4', '18080'): bind_opts
})

Should be

@openziti.zitify(bindings={
    ('1.2.3.4', 18080): bind_opts
})

Or, add support for either string or numeric data types

@gberl002 gberl002 added the bug Something isn't working label Mar 30, 2023
@ekoby ekoby closed this as completed in #49 Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant