Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identities Dir Functionality Broken #461

Open
NicFragale opened this issue Jul 28, 2022 · 1 comment
Open

Identities Dir Functionality Broken #461

NicFragale opened this issue Jul 28, 2022 · 1 comment
Labels
bug Something isn't working ziti-edge-tunnel

Comments

@NicFragale
Copy link

The ZET functionality to ascribe identities for running against is either direct to one with (--identity [path/to/json]) or multiples with (--identity-dir [path/]. When the --identity-dir syntax is used, the ZET binary seems to not read anything in the directory. Further, it seems like it launches multiple instances of ZET causing errors to return stating certain things that it performs at startup are already done. Single/direct --identity still works however.

ZET versio 0.19.6
zet-identity

@scareything
Copy link
Member

This happens because special logic that initializes the dns IP range from a config file is invoked when run with -I, and the logic is faulty. Specifically, get_ip_range_from_config() assumes the DNS range starts with the IP address that is assigned to the tun interface.

To be clear, "config file" in this case refers not to an identity json file, but config.json as consumed by Ziti Desktop Edge for Windows. As of now this notion of a "config file" should not be processed by ziti-edge-tunnel on Linux.

To fix this, I think we either need to avoid the config file logic entirely on Linux (e.g. differentiate between --identity-dir and --config) or/and specifically add the DNS IP to the tunnel status model (and also to config.json)

@dovholuknf dovholuknf added bug Something isn't working ziti-edge-tunnel labels Aug 1, 2022
@dovholuknf dovholuknf changed the title ZITI-EDGE-TUNNEL: Identities Dir Functionality Broken Identities Dir Functionality Broken Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ziti-edge-tunnel
Projects
None yet
Development

No branches or pull requests

3 participants