Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS queries are not sent to upstream DNS server #802

Closed
scareything opened this issue Feb 19, 2024 · 0 comments · Fixed by #803
Closed

DNS queries are not sent to upstream DNS server #802

scareything opened this issue Feb 19, 2024 · 0 comments · Fixed by #803

Comments

@scareything
Copy link
Member

scareything commented Feb 19, 2024

#774 correctly added a check to DNS queries to ensure that recursion was requested before sending to the upstream DNS server, however there is problem with how the DNS flags are assigned, and this prevents queries from being sent to the upstream server when it is set.

The DNS flags are being set by overlapping a bit field with the uint16 value from the message, but this isn't portable. Instead we need to retrieve the individual flags out of the message with masking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant