Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete the auth cookie if it's not needed #512

Closed
qrkourier opened this issue Jan 4, 2024 · 1 comment · Fixed by #524
Closed

delete the auth cookie if it's not needed #512

qrkourier opened this issue Jan 4, 2024 · 1 comment · Fixed by #524
Assignees
@qrkourier
Labels
enhancement Enhancement of an existing feature
Milestone
v0.4

Comments

@qrkourier
Copy link
Member

The cookie's domain scope is broad to support the oauth flow, so it's sent whether or not the share needs it. Delete the cookie when oauth is not enabled in frontend's http.go.
@qrkourier qrkourier self-assigned this Jan 4, 2024
@michaelquigley michaelquigley added the enhancement Enhancement of an existing feature label Jan 5, 2024
@michaelquigley
Copy link
Collaborator

Move this into the Development column on the roadmap board when you start working on it.

@michaelquigley michaelquigley added this to the v0.4 milestone Jan 5, 2024
@qrkourier qrkourier linked a pull request Jan 9, 2024 that will close this issue
delete the zrok-access cookie if not oauth #524
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qrkourier qrkourier

Labels
enhancement Enhancement of an existing feature
Projects
zrok Development Roadmap
Status: Done
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

delete the zrok-access cookie if not oauth openziti/zrok
2 participants
@qrkourier @michaelquigley