Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Improvements #89

Closed
4 of 6 tasks
operand opened this issue Jul 21, 2023 · 1 comment
Closed
4 of 6 tasks

API Improvements #89

operand opened this issue Jul 21, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@operand
Copy link
Owner

operand commented Jul 21, 2023

This issue is about making a number of API and internal improvements. Rather than create issues for each I'm listing them together here. Most of these are relatively small and could be fixed together. Some of them will be breaking API changes so it makes sense to try to bundle some before the next version increment.

If you have thoughts on these or other API improvements you'd like to see please share.

  • Remove "id queue" declarations in AMQPSpace
    Instead use ack/timeouts to return a "not found" error. It wastes resources on the server and isn't foolproof anyway.
  • Move thread event declarations out of Agent class
    This would keep all the threading details in the Space class making the Agent class more portable
  • Remove colorama dependency
  • Wider Python support including MicroPython
  • Broadcasts should be self-received
    This was a hasty choice made early on and I just haven't gotten around to changing it. The current pattern is not the standard way that a broadcast is handled. The API shouldn't be surprising like this.
  • ...
@operand operand added the enhancement New feature or request label Jul 21, 2023
@operand operand self-assigned this Aug 8, 2023
@operand
Copy link
Owner Author

operand commented Aug 9, 2023

most of this was addressed with 1.3 so I'm closing this issue. I'll make a new issue for wider python support.

@operand operand closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant