Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite - Ensure we handle message changed and message deleted events #366

Closed
JudsonStevens opened this issue Jan 25, 2022 · 1 comment
Closed

Rewrite - Ensure we handle message changed and message deleted events #366

JudsonStevens opened this issue Jan 25, 2022 · 1 comment
Assignees
@JudsonStevens
Labels
general: good first issue Good for newcomers priority: low This is an issue that is fine sitting for a while project: rewrite This issue applies to the rewrite of Pybot status: done The issue has been completed and the associated pull requests have been merged type: code change Issue requires changes to the code base type: enhancement Issue enhances a feature by adding more functionality

Comments

@JudsonStevens
Copy link
Collaborator

We need to make sure we are handling the generic message changed and message deleted events. This is similar to

operationcode-pybot/pybot/endpoints/slack/messages.py

Line 71 in 17b738a

async def message_changed(event: Message, app: SirBot):
in the current bot. We should be logging that the event happened.
@JudsonStevens JudsonStevens added type: enhancement Issue enhances a feature by adding more functionality general: good first issue Good for newcomers priority: low This is an issue that is fine sitting for a while project: rewrite This issue applies to the rewrite of Pybot type: code change Issue requires changes to the code base status: accepted The issue has been accepted but still needs to be addressed labels Jan 25, 2022
@JudsonStevens JudsonStevens self-assigned this Jan 25, 2022
@JudsonStevens
Copy link
Collaborator Author

This has been implemented with a simple logger event when the message event happens.

@app.event("message")
async def handle_message_event(body: dict[str, Any], context: AsyncBoltContext) -> None:
    logger.info("STAGE: Processing message event...")
    await context.ack()

@JudsonStevens JudsonStevens added status: done The issue has been completed and the associated pull requests have been merged and removed status: accepted The issue has been accepted but still needs to be addressed labels Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JudsonStevens JudsonStevens

Labels
general: good first issue Good for newcomers priority: low This is an issue that is fine sitting for a while project: rewrite This issue applies to the rewrite of Pybot status: done The issue has been completed and the associated pull requests have been merged type: code change Issue requires changes to the code base type: enhancement Issue enhances a feature by adding more functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JudsonStevens