Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/scaffold: fix go.mod scaffolds using openshift/api replacement #2466

Merged

Conversation

joelanford
Copy link
Member

Description of the change:
Add a replace line in go.mod scaffolds to fix broken dependency from OLM, which was caused by a tag that was removed from openshift/api in an effort to make that repo more Go module friendly.

Motivation for the change:
Closes #2394

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 25, 2020
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2020
@joelanford joelanford merged commit 9bc57b7 into operator-framework:master Jan 27, 2020
@joelanford joelanford deleted the fix-openshift-api-dep branch January 27, 2020 19:19
@joelanford
Copy link
Member Author

/cherry-pick v0.15.x

@openshift-cherrypick-robot

@joelanford: new pull request created: #2470

In response to this:

/cherry-pick v0.15.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go mod dependency fail when creating a new operator
4 participants