Confusion on logging levels

[criscola]

Type of question

Open question

Question

What did you do?

ctrl.SetLogger(zap.Level(zapcore.Level(3))))

in my Reconcile method:

logger.V(3).Info("Reconcile called")

What did you expect to see?

I expected to see "Reconcile called" in my output logs.

What did you see instead? Under which circumstances?

Nothing.

Environment

Operator type:

/language go

Additional context

If I read the docs for zapcore.Level, it says "A Level is a logging priority. Higher levels are more important.", but here's what the docs for the Logger interface is saying "[..] higher verbosity level means a log message is less important", so it looks like a contradiction.

Am I misunderstanding how the logging levels are supposed to work? To me, the intention of the Logger interface appears more sensed, but when I try to manually set the logging level of zap, the behavior is not what I expect. Sorry if this is the wrong place to ask, but as the operator-sdk automatically scaffolds zap and logr together I thought it would be appropriated to talk about it here.

How do I set the desired level of logging manually (not through BindFlag)?

[kensipe]

In the process of investigating. While this issue remains here for tracking, this is really a kubebuilder / controller-runtime issue / decision. We will get clarification which hopefully results in documentation that will be posted here.

[kensipe]

https://kubernetes.slack.com/archives/CAR30FCJZ/p1618859524142700

[estroz]

TL;DR: the level should be zapcore.Level(-3).

Created a PR to help clarify this in controller-runtime: kubernetes-sigs/controller-runtime#1485

[criscola]

Thank you @estroz and @kensipe, this line of godoc is going to save some head-scratching 😃.

[kensipe]

for those inclined to read... I completely agree :) thanks for reporting and following up!