Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider tagging releases #22

Closed
KwadroNaut opened this issue Oct 25, 2019 · 4 comments
Closed

Consider tagging releases #22

KwadroNaut opened this issue Oct 25, 2019 · 4 comments

Comments

@KwadroNaut
Copy link
Contributor

The more activity, the higher the probability that something breaks. I'd like to be able to fetch the latest stable version and use that. When there are security updates or bug fixes, I'd like to be upgrade, without breaking changes like iat-mode vs iatmode, or if using a method that gets removed, it's great to know about that.

Thanks for considering!

@CryptoSax
Copy link
Collaborator

the main reason we had to make a few of the changes like iat-mode was due mostly to conforming the spec. We also plan to start implementing go modules soon, which from my understanding should help with different releases being unstable. So far, the current release should hopefully be the most stable. If not, i'm going to not close the issue yet so i can remember to provide a more stable version for you in the event that this one has major issues

@CryptoSax
Copy link
Collaborator

We will start pushing regular releases moving forward! Thanks again for the feedback

@KwadroNaut
Copy link
Contributor Author

Thanks, makes sense!

the main reason we had to make a few of the changes like iat-mode was due mostly to conforming the spec.

Wait, which spec? I looked at Pluggable-Transports/Pluggable-Transports-spec@8cab0d7

  • Go Tranport API v2.1 Dial(nodeID *ntor.NodeID, publicKey *ntor.PublicKey, sessionKey *ntor.Keypair, iatMode int) *net.Conn
  • Dispatcher IPC Interface v2.1 ARGS:cert=60RNHBMRrf+aOSPzSj8bD4ASGyyPl0mkaOUAQsAYljSkFB0G8B8m9fGvGJCpOxwoXS1baA;iatMode=0
  • PTSpecV2Draft2.pdf func New(nodeID *ntor.NodeID, publicKey *ntor.PublicKey, sessionKey *ntor.Keypair, iatMode int) *Transport same document, just a bit lower: ARGS:cert=HszPy3vWfjsESCEOo9ZBkRv6zQ/1mGHzc8arF0y2SpwFr3WhsMu8rK0zyaoyERfbz3ddFw,iat-mode=0
    Same issue in pt-2_0.pdf, I presume you understand my confusion.

@colthreepv
Copy link

Up for this issue.
I wanted to create a docker image for this project, but version 3.0.0 does not compile, so I am forced to use master, thus creating an unreliable Docker Image 😞 relying on latest tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants