Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to make minSdk=14 #8

Closed
trietbui85 opened this issue Jun 30, 2015 · 1 comment
Closed

Is it possible to make minSdk=14 #8

trietbui85 opened this issue Jun 30, 2015 · 1 comment

Comments

@trietbui85
Copy link

I know this lib is using some API from Android API 18.

The Keystore system is used by the KeyChain API as well as the Android Keystore provider feature that was introduced in Android 4.3 (API level 18).

Therefore, the sample app has minSdkVersion=18. However, could you please decrease its minSdkVersion to 14, with a wrapper to use default SharedPreferences if device API version from 14 to 17, or use secure preferences if API >= 18?

@vashisthg
Copy link
Contributor

I fear that it may cause some developers to accidentally use the library in lower versions thinking that share preferences are being encrypted. Developers could fork the repos and use it as they want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants