Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LED Support on HK1 Box (S905x3) #1119

Closed
osering opened this issue Mar 1, 2023 · 2 comments
Closed

Add LED Support on HK1 Box (S905x3) #1119

osering opened this issue Mar 1, 2023 · 2 comments

Comments

@osering
Copy link

osering commented Mar 1, 2023

Hello!

Could you please add LED module support on HK1 Box (S905x3).

Originally it has 2 leds (blue&red) next to VFD display, but they are not active and there is no even a mentioning of 'gpio-leds' in respective dtb (for instance, older meson-gxbb-mxq-pro-plus.dtb contains it) .
When running, folder /sys/class/leds/ is empty (description of this class here https://docs.kernel.org/leds/leds-class.html).
In Armbian forum there has been discussion on "how to add leds" [https://forum.armbian.com/topic/112-dtb-howto-add-leds/].

In another bug report ([https://github.com/unifreq/linux-5.15.y/issues/18]) this problem is highlighted and contains even code which is allegedly missing (have not checked):


leds {
    compatible = "gpio-leds";
    status = "okay";
    sys_led {
        label = "sys_led";
        gpios = <0x75 0x0b 0x00>; //0x75是bank@14的phandle,注意修改自己的
        default-state = "on";
        linux,default-trigger = "default-on";
    };
};

zvfd {
    compatible = "z,vfd";
    dev_name = "zvfd";
    status = "okay";
};

LEDs could be used (blink, pulse/heartbeat, brightness) to indicate network/storage/cpu activity, eth speed 10/100/1000, excessive temperature (none kbd-scrolllock kbd-numlock kbd-capslock kbd-kanalock kbd-shiftlock kbd-altgrlock kbd-ctrllock kbd-altlock kbd-shiftllock kbd-shiftrlock kbd-ctrlllock kbd-ctrlrlock usbport usb-gadget usb-host disk-activity disk-read disk-write ide-disk mtd nand-disk) etc.

P.S. Moreover it should be reassessed if commands armbian-led (openwrt-led) is the most appropriate and shouldn't be renamed to armbian-vfd or armbian-display and armbian-led used for led control.

Thanks for your great job on "tvbox linux"!

@ophub
Copy link
Owner

ophub commented Mar 1, 2023

unifreq/linux-5.15.y#38

#414

This was discussed and submitted by users before, but it was not merged because the code was not standardized.

armbian-led can be renamed armbian-openvfd

@ophub
Copy link
Owner

ophub commented Mar 1, 2023

119a734

renamed

@ophub ophub closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants