Skip to content
This repository has been archived by the owner on Apr 21, 2024. It is now read-only.

Works on Greasemonkey #1

Closed
Carcosian-TMG opened this issue Nov 2, 2022 · 3 comments
Closed

Works on Greasemonkey #1

Carcosian-TMG opened this issue Nov 2, 2022 · 3 comments
Assignees

Comments

@Carcosian-TMG
Copy link

  • The script works using Violentmonkey version 2.13.3. Have yet to try it using Greasemonkey.
  • The script does not work on Chrome, and breaks the loading of the original script, which, as far as I can tell, can only be fixed by clearing the cookies for slowroads.io.

Feature Suggestion: Add tooltips to the settings, to make it easier to grasp what each setting affects.

@Opinion
Copy link
Owner

Opinion commented Nov 2, 2022

Thanks for the info on Greasemonkey! I'll update the readme later today.

I didn't include any tooltips because I don't actually know how each setting affect the car. Each setting has the same name as the property they are linked to.
Some are more obvious than others, but it seems to me that settings can have multiple effects (even "accel").

@Opinion Opinion self-assigned this Nov 2, 2022
@Opinion
Copy link
Owner

Opinion commented Nov 2, 2022

I just tested with Greasemonkey but I couldn't get it to work. Greasemonkey handles window.propertyHere differently. For Greasemonkey I need to access these properties through unsafeWindow.
https://wiki.greasespot.net/UnsafeWindow

To add Greasemonkey support I have to replace all instances of window. Make them check unsafeWindow first and use window as a fallback.

BTW, I also tested the script in Violentmonkey and it works perfectly there without any changes.

@Opinion
Copy link
Owner

Opinion commented Nov 5, 2022

Greasemonkey support has been added. Userscript version bumped to 1.1.
Closing issue.

@Opinion Opinion closed this as completed Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants