Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

JSON subdivision #117

Closed
Srykah opened this issue Sep 22, 2019 · 3 comments
Closed

JSON subdivision #117

Srykah opened this issue Sep 22, 2019 · 3 comments
Labels
enhancement When the issue is proposing an enhancement
Milestone

Comments

@Srykah
Copy link
Collaborator

Srykah commented Sep 22, 2019

JSON files each contain all their respective data (for example, the JSON file for the attacks contains ALL the attacks in the game) ; they should be broken into one file per data item (so, in an attacks folder, have a different JSON file for each attack and so on)

This will help readability, ease of contributing and loading times if we ever want to multithread it one day ^^

@milkyroute milkyroute added enhancement When the issue is proposing an enhancement read and removed read labels Sep 22, 2019
@TelloViz
Copy link
Contributor

This goes along with what I was thinking about the map.json file.

  • One map per file

  • A table of contents sort of file containing a list of maps (I'm not sure how JSON works..?)

@Srykah
Copy link
Collaborator Author

Srykah commented Nov 26, 2019

With the help of std::filesystem we don't even need a table of contents ^^

@milkyroute milkyroute added this to To do in Code improvement Nov 27, 2019
@milkyroute milkyroute added this to the For the 0.17 milestone Nov 27, 2019
@Srykah Srykah moved this from To do to Backlog in Code improvement Mar 18, 2020
@milkyroute
Copy link
Member

I fixed this with #164 for the maps, we'll see if we split other things but it won't be a problem in the code so I consider this issue fixed.

Code improvement automation moved this from Backlog (planned for later) to Done May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement When the issue is proposing an enhancement
Projects
Development

No branches or pull requests

3 participants