firewall: repair logic for ICMP fixup required by pfctl after refactor

PR: https://forum.opnsense.org/index.php?topic=7060.0 (cherry picked from commit a591cf1)
opnsense · Jan 30, 2018 · f26883d · f26883d
1 parent 612a96e
commit f26883d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php b/src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php
@@ -222,14 +222,14 @@ private function parseFilterRules()
             }
             // icmp-type switch (ipv4/ipv6)
             if ($rule['protocol'] == "icmp" && !empty($rule['icmptype'])) {
-                if ($ipproto == 'inet') {
+                if ($rule['ipprotocol'] == 'inet') {
                     $rule['icmp-type'] = $rule['icmptype'];
-                } elseif ($ipproto == 'inet6') {
+                } elseif ($rule['ipprotocol']== 'inet6') {
                     $rule['icmp6-type'] = $rule['icmptype'];
                 }
             }
             // icmpv6
-            if ($ipproto == 'inet6' && !empty($rule['protocol']) && $rule['protocol'] == "icmp") {
+            if ($rule['ipprotocol'] == 'inet6' && !empty($rule['protocol']) && $rule['protocol'] == "icmp") {
                 $rule['protocol'] = 'ipv6-icmp';
             }
             // set prio