Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code image needs white border #2430

Closed
marjohn56 opened this issue May 30, 2018 · 6 comments
Closed

QR code image needs white border #2430

marjohn56 opened this issue May 30, 2018 · 6 comments
Assignees
Labels
bug Production bug

Comments

@marjohn56
Copy link
Member

marjohn56 commented May 30, 2018

The QR code does not work for dark themes as there is no border around the image, otherwise known as the quiet zone. See...

https://web.archive.org/web/20110812190511/http://raidenii.net/files/datasheets/misc/qr_code.pdf

As reported https://forum.opnsense.org/index.php?topic=6885.0

@AdSchellevis
Copy link
Member

It seems like the qr-code module isn't really maintained anymore, same issue is in the pull requests https://github.com/jeromeetienne/jquery-qrcode/pull/43/files let me try to incorporate this and see how that pins out

@AdSchellevis AdSchellevis self-assigned this May 31, 2018
@AdSchellevis AdSchellevis added the bug Production bug label May 31, 2018
@AdSchellevis
Copy link
Member

@marjohn56 can you try 2f247f2 ?

@marjohn56
Copy link
Member Author

Looks the same, still no border.

@AdSchellevis
Copy link
Member

cache?
image

@marjohn56
Copy link
Member Author

Strangely enough I was looking through the same https://github.com/jeromeetienne/jquery-qrcode and found another method, that didn't work either.... then I cleared the cache. :)

Now your version and mine both work.... :)

Nice one Ad, another one bites the dust.

@AdSchellevis
Copy link
Member

Thanks for confirming Martin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Production bug
Development

No branches or pull requests

2 participants