API issue with getFirmwareConfig (400: not found)

[clementmoulin]

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

• I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug

Since last versions (I would say 23.1.x cannot tell exactly which one), the route API core/firmware/getfirmwareconfig is not working anymore.

To Reproduce

curl -k -u '...':'...' http://localhost/api/core/firmware/getfirmwareconfig -v
[...]
> GET /api/core/firmware/getfirmwareconfig HTTP/1.1
> Host: localhost
[...]
< HTTP/1.1 400 Bad Request
[...]
< Server: OPNsense
<
* Connection #0 to host localhost left intact
{"message":"action getfirmwareconfig not found","status":400}

Expected behavior

Answer from API :)

Describe alternatives you considered

N/A

Screenshots

N/A

Relevant log files

N/A

Additional context

N/A

Environment

Software version used and hardware type if relevant, e.g.:

OPNsense 23.1.5 to 23.1.11 (amd64, OpenSSL).

[clementmoulin]

OK. I have made some investigations through GUI, and it seems that routes have been updated and now are named api/firmware/set, api/firmware/get and api/firmware/get_options.

Documentation should be updated : https://docs.opnsense.org/development/api/core/firmware.html

[AdSchellevis]

uniformed in 4c65524, I'll make sure to update the api docs before the 23.7 release

[AdSchellevis]

I think we can close this with opnsense/docs@8f5ea36

[clementmoulin]

I don't see any update about core/firmware/ routes in that commit.

[AdSchellevis]

it looks like this one is excluded from our automated procedures, let me check if we can fix this for future changes as well.

[AdSchellevis]

we do have to do this manually it seems, opnsense/docs@e747ad1 should be it then.