Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/haproxy: service reconfigure consolidation #455

Closed
fichtner opened this issue Jan 1, 2018 · 2 comments
Closed

net/haproxy: service reconfigure consolidation #455

fichtner opened this issue Jan 1, 2018 · 2 comments
Assignees
Labels
feature Adding new functionality

Comments

@fichtner
Copy link
Member

fichtner commented Jan 1, 2018

Due to c458c3c7 it seems the reload is a bit strange / error-prone. Rework this for clarity. Ticket for feedback and discussion by @fraenki

@fichtner fichtner added the feature Adding new functionality label Jan 1, 2018
@fichtner fichtner self-assigned this Jan 1, 2018
@fraenki fraenki assigned fraenki and unassigned fichtner Jan 13, 2018
@fraenki
Copy link
Member

fraenki commented Jan 13, 2018

@fichtner Just noticed this too while working on other HAProxy stuff yesterday. I think it's solved by switching to the new mutable service controller (see #483, especially 7381101).

@fraenki fraenki closed this as completed Jan 13, 2018
@fichtner
Copy link
Member Author

Thanks! This means [reload] is now unused and could be removed from the configd actions.

Or you implement a reload logic hook like web proxy:

https://github.com/opnsense/core/blob/master/src/opnsense/mvc/app/controllers/OPNsense/Proxy/Api/ServiceController.php#L46-L57

Returning "0" in this function will execute a reload. Returning "1" is the default for the mutable controller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new functionality
Development

No branches or pull requests

2 participants