Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UninitializedPropertyAccessException in LessonThumbnailImageView for thumbnailDownloadUrlTemplate #1571

Open
rt4914 opened this issue Aug 7, 2020 · 3 comments
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Aug 7, 2020

LessonThumbnailImageView injects 3-4 different values which works correctly on all screens except one screen, StoryActivity, when there are more than 2-3 items. This has something to do with how the injection works with recyclerview and data binding.
One of the reasons that was mentioned is that it might be happening because the bindings are evaluated before the view is attached to window.

Some of the points there were discussed in team meeting are:
Suggest starting with a test to repro the issue in a test environment locally to better understand why the issue happens, then we can reason about the approach to repro the issue & try to fix it more broadly
Should look into bringing up view injection earlier in view lifecycle (e.g. constructor)
If current injection logic doesn't work in the constructor, might be feasible to change view scope to be a child of application instead of fragment which should definitely allow injection in constructors (though this limits our design options for views)

One resource shared by Pulkit is:
google/dagger#720

We should write a test that tries to inflate the view via data-binding & set properties on it before adding the view to an actual layout to render. This can possibly result in crash and based on that we can inspect the exact issue.

The main problem is that we have seen this crash only twice (Rajat + Akshay) and after that we have not been able to replicate it and therefore this needs to be investigated in detail.

@rt4914 rt4914 self-assigned this Aug 7, 2020
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. Where: Topics/Stories labels Aug 7, 2020
@rt4914 rt4914 added this to the Alpha milestone Aug 7, 2020
@rt4914
Copy link
Contributor Author

rt4914 commented Aug 7, 2020

For now, keeping this in Alpha milestone, might shift this to Beta depending upon if someone encounters this issue or not.

@BenHenning
Copy link
Sponsor Member

Going to take a stab at this later this week.

@BenHenning
Copy link
Sponsor Member

Actually, since it's fixed let's actually move this to beta.

@BenHenning BenHenning modified the milestones: Alpha, Beta Aug 18, 2020
@BenHenning BenHenning modified the milestones: Beta, Beta MR1, Beta MR2 Jun 11, 2022
@Broppia Broppia added issue_type_bug Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Impact: Low Low perceived user impact (e.g. edge cases). and removed Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta MR2 milestone Sep 16, 2022
@BenHenning BenHenning removed their assignment Sep 20, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_user_developer labels Mar 29, 2023
@adhiamboperes adhiamboperes added Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. work label added labels May 3, 2023
@adhiamboperes adhiamboperes added Impact: Low Low perceived user impact (e.g. edge cases). and removed Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Priority: Essential This work item must be completed for its milestone. labels Jun 15, 2023
@adhiamboperes adhiamboperes added the good first issue This item is good for new contributors to make their pull request. label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

5 participants