Ensure entire license text is displayed for all the copyright licenses #3738
Labels
enhancement
End user-perceivable enhancements.
good first issue
This item is good for new contributors to make their pull request.
Impact: Low
Low perceived user impact (e.g. edge cases).
Issue: Needs Clarification
Indicates that an issue needs more detail in order to be able to be acted upon.
Work: Medium
The means to find the solution is clear, but it isn't at good-first-issue level yet.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Projects
Reference Link - https://stackoverflow.com/a/51733275/12215015
We cannot have a string that is larger than 32,767 bytes (encoded in UTF-8) in your APK file but some license texts (like
CDDL + GPLv2
license) that are generated by running theRetrieveLicenseTexts.kt
script are larger than 32,767 bytes so they can not be displayed directly in the UI and we only show the license link in these cases.We should display the license texts whenever possible and hence we need another solution to support displaying large license texts.
Potential solutions
Rather than storing the license texts in the third_party_dependencies.xml file, we can store them in a textproto file and parse the textproto file to display the license texts.
Rather than storing the license text in a single string, we can split the license text before the first whitespace character before the
max_limit_of_chars
store the text in an array of strings. We can then concatenate all the strings of the array while displaying the license texts in the UI.The text was updated successfully, but these errors were encountered: