Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet points show up weirdly in the app #4855

Closed
seanlip opened this issue Jan 25, 2023 · 11 comments · Fixed by #4846
Closed

Bullet points show up weirdly in the app #4855

seanlip opened this issue Jan 25, 2023 · 11 comments · Fixed by #4846
Assignees

Comments

@seanlip
Copy link
Member

seanlip commented Jan 25, 2023

Describe the bug
Bullet points seem to show up misaligned in the app.

To Reproduce
Steps to reproduce the behavior:

I only know how to reproduce this on the alpha-kenya build. Here are screenshots from a few places:

(a) Multiplication > Revision Card > Techniques of Multiplication
Screenshot_20230125-172138

(b) Multiplication > Lesson 1 > Final Card

Screenshot_20230125-172708

Expected behavior
The inner white bullet points should be closer to their text.

Environment

  • App version (you can get this through system app settings or via the admin controls menu in-app): 0.10-alpha_kenya
@Parth27904
Copy link

Hey @seanlip ! I am a beginner at android and I would like to work on this problem. Can you please assign this to me? I plan on the usage of BulletSpan.

@seanlip
Copy link
Member Author

seanlip commented Jan 25, 2023

@Parth27904 Can you try doing this locally and show a screenshot/video of it working, as well as describe the approach you're taking? If it looks good and the approach is sound, we can assign it to you.

Thanks!

@Parth27904
Copy link

@seanlip I am a beginner so can you help me with some hints or resources about this problem

@seanlip
Copy link
Member Author

seanlip commented Jan 26, 2023

@Parth27904 I'm afraid not -- this is an issue which requires investigation. If you would like to help out, I would suggest following the instructions on the wiki and focusing mainly on good first issues that you are confident you can tackle.

Note that, before assigning you to an issue, we will always ask you for an explanation/proof of how you plan to do it, so it might be worth trying to see if you can get it working locally first.

@Abhinav-1111
Copy link

I want to work on this issue . Please assign me this issue.

@seanlip
Copy link
Member Author

seanlip commented Jan 29, 2023

@Abhinav-1111 Please see the second paragraph of the previous comment. Feel free to post if you have an explanation of how you plan to solve it (please provide details of which files you plan to change etc.) -- thanks.

@Abinash6000
Copy link
Contributor

Abinash6000 commented Jan 29, 2023

@seanlip I built the app from android studio but it doesn't have any multiplication section in it. Am I missing something?
image

@seanlip
Copy link
Member Author

seanlip commented Jan 30, 2023

@Abinash6000 Ah yes, sorry, I think this needs access to a revision card with bullet points or the prod build mentioned in the description. I think @BenHenning is currently working on fixing it though (for a study we are running) so perhaps finding a different issue would be better. You can see our good first issues at https://github.com/oppia/oppia-android/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 -- maybe pick one of those?

Thanks!

@sumanbmondal
Copy link

@seanlip This issue can also be reproduced by navigating to FAQs or Privacy Policy in the Help Section.
bulletpts
bulletpts2

@seanlip
Copy link
Member Author

seanlip commented Jan 31, 2023

Thanks @sumanbmondal -- yup, good catch. I think @BenHenning is fixing this in #4846 ... it might be worth checking if this issue is resolved once you merge those changes in?

@sumanbmondal
Copy link

@seanlip Yup, I'm definitely watching and learning as much as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment