Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: model/src/main/proto/BUILD.bazel has build issues #5305

Closed
BenHenning opened this issue Jan 16, 2024 · 0 comments · Fixed by #5138
Closed

[BUG]: model/src/main/proto/BUILD.bazel has build issues #5305

BenHenning opened this issue Jan 16, 2024 · 0 comments · Fixed by #5138
Assignees
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@BenHenning
Copy link
Sponsor Member

Describe the bug

In model/src/main/proto/BUILD.bazel the proto feedback_reporting_proto requires languages.proto but doesn't actually depend on it. This results in a build error, but only when building all targets in the app (e.g. bazel build //...) since, as of this issue, no library yet depends on feedback_reporting_proto.

Steps To Reproduce

Try to build all proto libraries, e.g.: bazel build //model/....

Expected Behavior

All model targets should build without any errors.

Screenshots/Videos

No response

What device/emulator are you using?

N/A

Which Android version is your device/emulator running?

N/A

Which version of the Oppia Android app are you using?

N/A

Additional Context

No response

@BenHenning BenHenning added bug End user-perceivable behaviors which are not desirable. triage needed Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Jan 16, 2024
@BenHenning BenHenning self-assigned this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
2 participants