Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: TestGitRepository can have environment-specific behavior #5306

Closed
BenHenning opened this issue Jan 16, 2024 · 0 comments · Fixed by #5138
Closed

[BUG]: TestGitRepository can have environment-specific behavior #5306

BenHenning opened this issue Jan 16, 2024 · 0 comments · Fixed by #5138
Assignees
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@BenHenning
Copy link
Sponsor Member

Describe the bug

TestGitRepository is currently written to assume that a global user and email has been set in the local git environment. This is inherently fragile as configurations outside the repository shouldn't affect the test environment.

Steps To Reproduce

Try to run TestGitRepositoryTest when no user.name or user.email is set for the machine's local global configuration.

Expected Behavior

TestGitRepository should be robust against global configurations by manually maintaining and setting a repository-local user name and email.

Screenshots/Videos

No response

What device/emulator are you using?

N/A -- test environment

Which Android version is your device/emulator running?

N/A -- test environment

Which version of the Oppia Android app are you using?

N/A -- test environment

Additional Context

No response

@BenHenning BenHenning added bug End user-perceivable behaviors which are not desirable. triage needed Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Jan 16, 2024
@BenHenning BenHenning self-assigned this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
2 participants